NEW (Extension) @W-13992309@ Remove duplicate suppress violations prompts on the same line #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jag-j
commented
Jun 5, 2024
| @@ -92,8 +92,8 @@ export async function activate(context: vscode.ExtensionContext): Promise<vscode | |||
| outputChannel | |||
| }); | |||
| }); | |||
| const removeSingleDiagnostic = vscode.commands.registerCommand(Constants.COMMAND_REMOVE_SINGLE_DIAGNOSTIC, (uri: vscode.Uri, diagnostic: vscode.Diagnostic) => { | |||
| _removeSingleDiagnostic(uri, diagnostic, diagnosticCollection); | |||
| const removeDiagnosticsInRange = vscode.commands.registerCommand(Constants.COMMAND_DIAGNOSTICS_IN_RANGE, (uri: vscode.Uri, range: vscode.Range) => { | |||
There was a problem hiding this comment.
For a better user experience, we should remove all diagnostics on a given line (or even a set of lines). That's because "// NOPMD" is generic and not specific to a rule. So, a line could have both apexdoc and unused var error and both should go away with the "// NOPMD" tag. This wasn't specifically called out in the acceptance criteria or anywhere else, but I think this is the right thing to do.
jag-j
commented
Jun 5, 2024
| const fixes: vscode.CodeAction[] = []; | ||
| if (this.documentSupportsLineLevelSuppression()) { | ||
| fixes.push(this.generateLineLevelSuppression()); | ||
| const lineNumber = this.diagnostic.range.start.line; |
There was a problem hiding this comment.
This is the main change. Even if we have multiple violations on a single line, we show only one "suppress violation" and that would add the "// NOPMD" tag.
stephen-carter-at-sf
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following: