NEW (Extension) @W-15640497@ Delta runs on SFGE - Phase 1 #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfeingold35
reviewed
Sep 17, 2024
package.json
Outdated
| @@ -36,6 +36,7 @@ | |||
| "cross-spawn": "^7.0.3", | |||
| "glob": "^8.0.3", | |||
| "globby": "^11.0.0", | |||
| "proxyquire": "^2.1.3", | |||
There was a problem hiding this comment.
Do you have a 3PP for this? Also, it doesn't look like this is used in production code, so should it be in devDependencies instead of dependencies?
There was a problem hiding this comment.
My bad! I intended this to a devDependencies as we discussed in the tea time last week. I have moved it now.
| */ | ||
| import * as fs from 'fs'; | ||
|
|
||
| export function getDeltaRunTarget(sfgecachepath:string, savedFilesCache:Set<string>): string[] { |
There was a problem hiding this comment.
Conceptually, it feels weird for this to be a utility method that accepts the Set, instead of having a class that encloses the Set and exposes a getDeltaRunTarget method.
But broadly speaking, I think this is fine.
src/extension.ts
Outdated
| const rerunFailedOnly = choice == '***Yes***'; | ||
| if (rerunFailedOnly) { | ||
| const rerunChangedOnly = choice == '***Yes***'; | ||
| if (rerunChangedOnly) { | ||
| // Do nothing for now. This will be implemented as part of W-15639759 |
There was a problem hiding this comment.
Does this comment need to change?
jag-j
force-pushed
the
jj/W-15640497
branch
2 times, most recently
from
1ba0d6d
to
ee4ecb2
Compare
jfeingold35
previously approved these changes
Sep 19, 2024
jfeingold35
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.