NEW (Extension) @W-16442046@ Apex guru fixer logic - to show and insert apex guru suggestions #116
Conversation
jag-j
requested review from
stephen-carter-at-sf and
jfeingold35
and removed request for
stephen-carter-at-sf
src/apexguru/apex-guru-service.ts
Outdated
| currentCode: Buffer.from(encodedCodeBefore, 'base64').toString('utf8'), | ||
| suggestedCode: Buffer.from(encodedCodeAfter, 'base64').toString('utf8'), |
There was a problem hiding this comment.
If currentCode and suggestedCode is equal to `` (i.e. empty)… does it show this in the popup box still?
I ask because I would have assumed that to trigger whether it shows up or not would be based on undefined or null instead. Because maybe the after code is indeed empty and we want to show that instead of hide it.
There was a problem hiding this comment.
As explained in slack, this doesn't show up.
There was a problem hiding this comment.
Maybe not today. But it could in the future.
Instead of
(prop: ApexGuruProperty) => prop.name === 'code_after')?.value ?? ''
Why not just send in the value always even if it is undefined.
Then your line
if (apexGuruViolation.suggestedCode) {
code could just switch to
if (apexGuruViolation.suggestedCode !== undefined) {
or maybe just
if (typeof apexGuruViolation.suggestedCode === 'string') {
so that it allows for empty strings.
src/lib/diagnostics.ts
Outdated
| if (engine === 'apexguru') { | ||
| const apexGuruViolation = violation as ApexGuruViolation; | ||
|
|
||
| if (apexGuruViolation.suggestedCode?.trim()) { |
There was a problem hiding this comment.
If the suggestedCode is empty... maybe that is because we are suggesting to replace it. Can we instead just explicitly check if the suggestedCode is undefined as a way of determining this.
There was a problem hiding this comment.
Ah! this is a super-edge case. But valid point. Let me take care of this.
No description provided.