NEW (Extension) @W-16442046@ Address review comments

forcedotcom · Aug 16, 2024 · d5bf863 · d5bf863
1 parent 3f1c22a
commit d5bf863
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/src/apexguru/apex-guru-service.ts b/src/apexguru/apex-guru-service.ts
@@ -128,8 +128,8 @@ export function transformStringToRuleResult(fileName: string, jsonString: string
     };
 
 	reports.forEach(parsed => {
-		const encodedCodeBefore = parsed.properties.find((prop: ApexGuruProperty) => prop.name === 'code_before')?.value ?? '';
-		const encodedCodeAfter = parsed.properties.find((prop: ApexGuruProperty) => prop.name === 'code_after')?.value ?? '';
+		const encodedCodeBefore = parsed.properties.find((prop: ApexGuruProperty) => prop.name === 'code_before')?.value;
+		const encodedCodeAfter = parsed.properties.find((prop: ApexGuruProperty) => prop.name === 'code_after')?.value;
 		const lineNumber = parseInt(parsed.properties.find((prop: ApexGuruProperty) => prop.name === 'line_number')?.value);
 
 		const violation: ApexGuruViolation = {
@@ -139,8 +139,8 @@ export function transformStringToRuleResult(fileName: string, jsonString: string
 			category: parsed.type, // Replace with actual category if available
 			line: lineNumber,
 			column: 1,
-			currentCode: Buffer.from(encodedCodeBefore, 'base64').toString('utf8'),
-			suggestedCode: Buffer.from(encodedCodeAfter, 'base64').toString('utf8'),
+			currentCode: encodedCodeBefore ? Buffer.from(encodedCodeBefore, 'base64').toString('utf8') : encodedCodeBefore,
+			suggestedCode: encodedCodeAfter ? Buffer.from(encodedCodeAfter, 'base64').toString('utf8') : encodedCodeAfter,
 		};
 
 		ruleResult.violations.push(violation);

diff --git a/src/lib/diagnostics.ts b/src/lib/diagnostics.ts
@@ -92,7 +92,7 @@ export class DiagnosticManager {
         if (engine === 'apexguru') {
             const apexGuruViolation = violation as ApexGuruViolation;
 
-            if (apexGuruViolation.suggestedCode) {
+            if (apexGuruViolation.suggestedCode !== undefined) {
                 diagnostic.relatedInformation = [
                     new vscode.DiagnosticRelatedInformation(
                         new vscode.Location(vscode.Uri.parse('Current Code'), range),

diff --git a/src/test/suite/apexguru/apex-guru-service.test.ts b/src/test/suite/apexguru/apex-guru-service.test.ts
@@ -176,7 +176,7 @@ suite('Apex Guru Test Suite', () => {
                   category: 'BestPractices',
                   line: 10,
                   column: 1,
-                  currentCode: '',
+                  currentCode: undefined,
                   suggestedCode: 'System.out.println("Hello World");'
               }]
           });