NEW (Extension) @W-15640497@ Make Delta runs a user visible setting

forcedotcom · Sep 20, 2024 · 10f23e0 · 10f23e0
1 parent 6ed70e6
commit 10f23e0
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 6 deletions.
diff --git a/package.json b/package.json
@@ -168,6 +168,11 @@
                     "type": "boolean",
                     "default": false,
                     "description": "Discover critical problems and performance issues in your Apex code with ApexGuru, which analyzes your Apex files for you. This feature is in a closed pilot; contact your account representative to learn more."
+                },
+                "codeAnalyzer.deltaRuns.enabled": {
+                    "type": "boolean",
+                    "default": false,
+                    "description": "***Enable delta run of Salesforce Graph Engine***"
                 }
             }
         },
@@ -187,7 +192,7 @@
                 },
                 {
                     "command": "sfca.runDfa",
-                    "when": "false"
+                    "when": "true"
                 },
                 {
                     "command": "sfca.removeDiagnosticsOnActiveFile",

diff --git a/src/extension.ts b/src/extension.ts
@@ -123,11 +123,7 @@ export async function activate(context: vscode.ExtensionContext): Promise<vscode
 	});
 
 	sfgeCachePath = path.join(createTempDirectory(), 'sfca-graph-engine-cache.json');
-	const runDfaOnWorkspaceCmd = vscode.commands.registerCommand(Constants.COMMAND_RUN_DFA, async () => {
-		await _runDfa(context);
-		savedFilesCache.clear();
-	});
-	context.subscriptions.push(runOnActiveFile, runOnSelected, runDfaOnSelectedMethodCmd, runDfaOnWorkspaceCmd, removeDiagnosticsOnActiveFile, removeDiagnosticsOnSelectedFile, removeDiagnosticsInRange);
+	context.subscriptions.push(runOnActiveFile, runOnSelected, runDfaOnSelectedMethodCmd, removeDiagnosticsOnActiveFile, removeDiagnosticsOnSelectedFile, removeDiagnosticsInRange);
 
 	if (apexGuruEnabled) {
 		const runApexGuruOnSelectedFile = vscode.commands.registerCommand(Constants.COMMAND_RUN_APEX_GURU_ON_FILE, async (selection: vscode.Uri, multiSelect?: vscode.Uri[]) => {
@@ -150,6 +146,14 @@ export async function activate(context: vscode.ExtensionContext): Promise<vscode
 		context.subscriptions.push(runApexGuruOnSelectedFile, runApexGuruOnCurrentFile);
 	}
 
+	if (SettingsManager.getSfgeDeltaRunsEnabled()) {
+		const runDfaOnWorkspaceCmd = vscode.commands.registerCommand(Constants.COMMAND_RUN_DFA, async () => {
+			await _runDfa(context);
+			savedFilesCache.clear();
+		});
+		context.subscriptions.push(runDfaOnWorkspaceCmd);
+	}
+
 	const documentSaveListener = vscode.workspace.onDidSaveTextDocument(document => {
         const filePath = document.uri.fsPath;
         savedFilesCache.add(filePath);

diff --git a/src/lib/settings.ts b/src/lib/settings.ts
@@ -53,4 +53,8 @@ export class SettingsManager {
     public static getApexGuruEnabled(): boolean {
         return vscode.workspace.getConfiguration('codeAnalyzer.apexGuru').get('enabled');
     }
+
+    public static getSfgeDeltaRunsEnabled(): boolean {
+        return vscode.workspace.getConfiguration('codeAnalyzer.deltaRuns').get('enabled');
+    }
 }
diff --git a/src/test/suite/settings.test.ts b/src/test/suite/settings.test.ts
@@ -185,4 +185,19 @@ suite('SettingsManager Test Suite', () => {
         expect(result).to.equal(mockAnalyzeOnSaveEnabled);
         expect(getConfigurationStub.calledOnceWith('codeAnalyzer.apexGuru')).to.be.true;
     });
+
+    test('getSfgeDeltaRunsEnabled should return the delta runs enabled setting', () => {
+        // ===== SETUP =====
+        const mockAnalyzeOnSaveEnabled = true;
+        getConfigurationStub.withArgs('codeAnalyzer.deltaRuns').returns({
+            get: Sinon.stub().returns(mockAnalyzeOnSaveEnabled)
+        });
+
+        // ===== TEST =====
+        const result = SettingsManager.getSfgeDeltaRunsEnabled();
+
+        // ===== ASSERTIONS =====
+        expect(result).to.equal(mockAnalyzeOnSaveEnabled);
+        expect(getConfigurationStub.calledOnceWith('codeAnalyzer.deltaRuns')).to.be.true;
+    });
 });