Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove method initializeServiceWithAttributes #123

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

peternhale
Copy link
Contributor

@W-16742418@
telemetry service init must have extensionContext to init properly
Removing the TelemetryServiceInterface method initializeServiceWithAttributes since it cannot safely fetch the extension context when an extension is activating.

@W-16742418@
telemetry service init must have extensionContext to init properly
@peternhale peternhale merged commit 8195f56 into main Sep 18, 2024
24 checks passed
@peternhale peternhale deleted the phale/W-16742418-change-interface branch September 18, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants