feat: check for command availability #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-16617918@ Add checks to see if target command is available before getting service.
peternhale
commented
Sep 4, 2024
| } | ||
| } | ||
|
|
||
| private static getCommands(): Promise<string[]> { |
There was a problem hiding this comment.
I had to add a simple method that I could mock to cover the actual call to vscode.commands.getCommands. Could not get a jest mock to properly hand the getCommands function.
daphne-sfdc
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
Approved! 🎉
Test plan here: https://salesforce.quip.com/bTabAKye8k2b ✅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-16617918@
Add checks to see if target command is available before getting service.