feat: add telemetry service #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@W-16507728@
daphne-sfdc
reviewed
Aug 22, 2024
daphne-sfdc
reviewed
Aug 22, 2024
daphne-sfdc
reviewed
Aug 22, 2024
daphne-sfdc
reviewed
Aug 22, 2024
Comment on lines
-29
to
+112
| ServiceType.Logger, | ||
| ServiceType.Telemetry, |
There was a problem hiding this comment.
I see that all instances of Logger in this test file are replaced with Telemetry. Are we no longer going to test Logger?
There was a problem hiding this comment.
Since telemetry is now the focus of the first service to to be officially exposed via this module, I figured the shift was reasonable.
Co-authored-by: Daphne Yang <[email protected]>
Co-authored-by: Daphne Yang <[email protected]>
daphne-sfdc
approved these changes
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds the necessary code to get an instance of the telemetry service exposed by vscode-core
What issues does this PR fix or reference?
@W-16507728@