feat: remove dependency on yeoman #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshanemc
reviewed
Jun 21, 2024
src/generators/sfGenerator.ts
Outdated
| customTemplatesRootPathOrGitRepo?: string; | ||
| sourceRootPartial?: string; | ||
| }): Promise<CreateOutput> { | ||
| const cwd = opts?.cwd ?? process.cwd(); |
There was a problem hiding this comment.
for the VSCode team: is this adequate for VSCode's usage? it's passing in the project dir to all the generators?
mshanemc
requested changes
Jun 21, 2024
There was a problem hiding this comment.
our plugin that uses this has pretty great NUT coverage (real fs across OSes, etc). I'd love to see those tests run for library changes to enable ongoing refactoring and dep maintenance for this lib.
If the lib owners aren't up for that, I'd like to see a run of them (maybe branch of a branch) to verify these changes don't affect output.
|
I still see one failing NUT on the plugin when I use this branch and your branch on the plugin (running locally)
|
mshanemc
reviewed
Jun 24, 2024
mshanemc
reviewed
Jun 24, 2024
peternhale
approved these changes
Jun 24, 2024
mshanemc
approved these changes
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes dependency on yeoman-generator and yeoman-environment
What issues does this PR fix or reference?
@W-16025380@