Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump dep for @salesforce/sfdx-lwc-jest to 3.1.0 #573

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

peternhale
Copy link
Contributor

What does this PR do?

bumps @salesforce/sfdx-lwc-jest to 3.1.0 so that module jest-environment-jsdom is installed
Bumps other dev deps to latest version

What issues does this PR fix or reference?

@W-14512085@ #5239

Copy link
Contributor

@CristiCanizales CristiCanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I tested it compiles successfully on the main repo ✅

:shipit:

Copy link
Member

@mingxuanzhangsfdx mingxuanzhangsfdx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I ran yarn build and it succeeded.

@peternhale peternhale merged commit 1c2fda2 into main Dec 6, 2023
8 checks passed
@peternhale peternhale deleted the phale/W-14512085-jest-environment-jsdom branch December 6, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants