Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: address feedback from yeoman update PR #476 #486

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gbockus-sf
Copy link
Contributor

What does this PR do?

  • Address feedback in PR for upgrading Yeoman
    • pin yeoman version
    • Move env.run call to use await/async
    • Add tests for projectGenerator and customInstallTask parameter.

@gbockus-sf gbockus-sf requested a review from mohanraj-r May 6, 2022 20:19
@gbockus-sf gbockus-sf requested a review from a team as a code owner May 6, 2022 20:19
@gbockus-sf gbockus-sf requested a review from smithgp May 6, 2022 20:19
reject(err);
});
});
await this.env.run(generatorNamespace, templateOptions);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same functionality with await/async

restore();
});

it('Should set the customInstallTask feature to false for the ProjectGenerator', () => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

went to add just this test, but then much us the file was uncovered so I went ahead and added some simple tests to cover the rest of the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants