Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: run shrinkwrap during sf-prepack #296

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

mdonnalley
Copy link
Contributor

  • Run npm shrinkwrap during sf-prepack
  • Start managing plugin's files
  • Add entires to .gitignore if they don't exist
    • if the CLEAN and CLEAN ALL segments exist, it will add the entries to the appropriate section (and remove them from anywhere else in the file)
    • if those segments don't exist, it will simply append the entries to the bottom of the file
  • Change postpack script for plugins to sf-clean
  • Remove shx devDep if it's not being used by any script

@W-14878497@

@shetzel
Copy link
Contributor

shetzel commented Feb 14, 2024

QA looks good. I linked this to a plugin and ran yarn. Here are some screenshots. Everything is as expected.

Screenshot 2024-02-14 at 3 08 19 PM Screenshot 2024-02-14 at 3 10 34 PM Screenshot 2024-02-14 at 3 11 11 PM

I also linked it to a library and ran yarn. Everything that was changed was expected. Screenshots:

Screenshot 2024-02-14 at 3 25 26 PM Screenshot 2024-02-14 at 3 26 23 PM

@shetzel shetzel merged commit 20692be into main Feb 14, 2024
12 checks passed
@shetzel shetzel deleted the mdonnalley/plugins-ship-shrinkwrap branch February 14, 2024 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants