Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: streamline devDeps into 2 buckets, provide defaults #240

Merged

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Oct 27, 2023

requires forcedotcom/eslint-config-salesforce-typescript#191. Once that merges and releases, use the new version in here instead of the beta.

devScripts will remove most devDeps and provide them to consumers, with support for overrides via sf-dev-rc.

most eslint functionality is provided by forcedotcom/eslint-config-salesforce-typescript#191

BREAKING CHANGES: you might need certain versions of dependencies and this would break you until you set the overrides.

also, provide some deeper docs for .sf-dev-rc

@W-14373783@

QA: use the beta tag release.

Proof of correctness salesforcecli/plugin-limits#674

@mdonnalley
Copy link
Contributor

@mshanemc since we're doing a major version bump here, do you want to also drop swc?

@mdonnalley
Copy link
Contributor

QA notes:

yarn add @salesforce/[email protected] --dev in plugin-telemetry
🟢 removed dev-scripts managed devDeps
🟢 yarn compile passes
🟢 yarn lint passes
🟢 yarn test passes
🟢 eslint in devDepOverrides in .sfdevrc prevents eslint from being removed
🟢 removing devDepOverrides in .sfdevrc allows dev-scripts to remove eslint dep

@mdonnalley mdonnalley merged commit bda55e3 into main Oct 30, 2023
8 checks passed
@mdonnalley mdonnalley deleted the sm/let-eslint-config-salesforce-typescript-handle-eslint-stuff branch October 30, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants