Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: replace .eslintrc.js with .eslintrc.cjs #209

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

mdonnalley
Copy link
Contributor

Replaces .eslintrc.js with .eslintrc.cjs so that we can begin migrating plugins to ESM

@W-14009603@

@mshanemc
Copy link
Contributor

mshanemc commented Aug 31, 2023

QA notes:

generated 5.7.1-qa.0 for local testing

updated in plugin-user

✅ git status

Changes not staged for commit:
  (use "git add/rm <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
        deleted:    .eslintrc.js
        modified:   package.json
        deleted:    test/.eslintrc.js
        modified:   yarn.lock

Untracked files:
  (use "git add <file>..." to include in what will be committed)
        .eslintrc.cjs
        test/.eslintrc.cjs

✅ test/.eslint.cjs extends: '../.eslintrc.cjs',

@mshanemc mshanemc merged commit e760b5b into main Aug 31, 2023
9 checks passed
@mshanemc mshanemc deleted the mdonnalley/cjs-eslint branch August 31, 2023 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants