CHANGE(pmd): @W-17099496@: Upgrade PMD to 7.7.0 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1170,7 +1170,7 @@ | |||
| "CodeStyle", | |||
| "javaLanguage" | |||
| ], | |||
| "description": "Methods that return boolean results should be named as predicate statements to denote this. I.e, 'isReady()', 'hasValues()', 'canCommit()', 'willFail()', etc. Avoid the use of the 'get' prefix for these methods.", | |||
| "description": "Methods that return boolean or Boolean results should be named as predicate statements to denote this. I.e., 'isReady()', 'hasValues()', 'canCommit()', 'willFail()', etc. Avoid the use of the 'get' prefix for these methods.", | |||
There was a problem hiding this comment.
The use of a goldfile is really serving its purpose well here.
I've confirmed that the only rule definition changes are the java rules changes as described in the https://docs.pmd-code.org/pmd-doc-7.7.0/pmd_release_notes.html
So looks good.
stephen-carter-at-sf
force-pushed
the
sc/W-17099496
branch
from
feb1a1f
to
b512574
Compare
Comment on lines
+281
to
+283
| beforeAll(() => { | ||
| jest.setTimeout(60000); | ||
| }); |
There was a problem hiding this comment.
Increasing timeout from default 5 seconds to 60 seconds to avoid sporadic failures.
jfeingold35
approved these changes
Oct 30, 2024
jag-j
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.