Bump xcode to 15.4 and iOS to 17.5 for CI. #3753
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandonpage
commented
Aug 14, 2024
| @@ -50,4 +50,11 @@ - (void)oauthCoordinatorDidCancelBrowserAuthentication:(SFOAuthCoordinator *)coo | |||
| XCTFail(@"ASWebAuthenticationSession auth flow is not supported in unit test framework"); | |||
| } | |||
|
|
|||
| - (void)oauthCoordinatorDidBeginNativeAuthentication:(nonnull SFOAuthCoordinator *)coordinator { | |||
There was a problem hiding this comment.
This fixes a warning.
bbirman
approved these changes
Aug 14, 2024
wmathurin
approved these changes
Aug 14, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3753 +/- ##
=======================================
Coverage 43.43% 43.43%
=======================================
Files 223 223
Lines 20566 20566
=======================================
Hits 8932 8932
Misses 11634 11634
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
The only test that failed is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.