Auth view notification with login reason #3732
Conversation
| @@ -78,6 +78,13 @@ typedef NS_ENUM(NSInteger, SFLogoutReason) { | |||
| SFLogoutReasonRefreshTokenRotated // "Refresh token rotated" | |||
| }; | |||
|
|
|||
| typedef NS_ENUM(NSInteger, SFLoginReason) { | |||
| SFLoginReasonUnknown, | |||
There was a problem hiding this comment.
these are tbd, I was thinking we should also have something for the AuthHelper entry point since that's only called by apps
| @@ -78,6 +78,13 @@ typedef NS_ENUM(NSInteger, SFLogoutReason) { | |||
| SFLogoutReasonRefreshTokenRotated // "Refresh token rotated" | |||
| }; | |||
|
|
|||
| typedef NS_ENUM(NSInteger, SFLoginReason) { | |||
| SFLoginReasonUnknown, | |||
| SFLoginReasonRestAPI, | |||
There was a problem hiding this comment.
When would it be SFLoginReasonRestAPI?
There was a problem hiding this comment.
I assumed that meant we try to refresh the access token but the auth token is expired.
There was a problem hiding this comment.
Whoops, I missed a file, for this one
There was a problem hiding this comment.
better naming ideas would be great :P
There was a problem hiding this comment.
Maybe we can match the logout reasons when applicable?
| [SFSDKCoreLogger i:[self class] format:@"Showing auth view, login reason: %@", reason]; // TODO string value | ||
| NSDictionary *userInfo = @{ kSFNotificationUserInfoCredentialsKey: coordinator.credentials, | ||
| kSFNotificationUserInfoAuthTypeKey: coordinator.authInfo, | ||
| kSFNotificationUserInfoLoginReasonKey: @(coordinator.authSession.oauthRequest.loginReason)}; |
There was a problem hiding this comment.
This reason should also be applied to the notification posted in the function below - - (void)oauthCoordinator:(SFOAuthCoordinator *)coordinator didBeginAuthenticationWithSession:(ASWebAuthenticationSession *)session
No description provided.