@W-16171422: [iOS] Update Native Login Sample App to include QR Code Login Flow #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Login Flow (Introduce `isQrCodeLoginEnabled`. Functional P.O.C.)
JohnsonEricAtSalesforce
force-pushed
the
feature/w-16171422_ios-update-native-login-sample-app-to-include-qr-code-login-flow
branch
from
2511af9
to
306949b
Compare
…Login Flow (Revert `Podfile`)
…Login Flow (Revert `project.pbxproj`)
…Login Flow (Self Review Cleanup, Pt. 1)
…Login Flow (Self Review Cleanup, Pt. 2)
…Login Flow (Revert `bootconfig.plist`)
…Login Flow (Improve Button Layouts)
wmathurin
reviewed
Sep 24, 2024
JohnsonEricAtSalesforce
force-pushed
the
feature/w-16171422_ios-update-native-login-sample-app-to-include-qr-code-login-flow
branch
from
5d69c18
to
9444796
Compare
…Login Flow (Revert Local Diagnostics)
JohnsonEricAtSalesforce
force-pushed
the
feature/w-16171422_ios-update-native-login-sample-app-to-include-qr-code-login-flow
branch
from
9444796
to
56983fe
Compare
wmathurin
approved these changes
Sep 30, 2024
bbirman
reviewed
Oct 1, 2024
iOSNativeSwiftTemplate/iOSNativeSwiftTemplate/AppDelegate.swift
Outdated
Show resolved
Hide resolved
…Login Flow (Updates To Instructions For Enabling QR Code Log In)
bbirman
approved these changes
Oct 1, 2024
wmathurin
approved these changes
Oct 1, 2024
JohnsonEricAtSalesforce
deleted the
feature/w-16171422_ios-update-native-login-sample-app-to-include-qr-code-login-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎸 Ready For Review! 🥁
This is the companion to forcedotcom/SalesforceMobileSDK-iOS#3759 . Most of the juicy details are there, but I did add a thorough self-review with code walk through here as well.
Support for deep linking QR Code Log In from an external QR code reader is deferred for a fast follow in W-16814802
Here's a screenshot showing the new button layouts in the login selection type view.
