W-16171426: [Android] Update Native Login Sample App to include QR Code Login Flow #417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's worth noting I did intend to include commits from the spike performed by @wmathurin. I rebased his branch on |
JohnsonEricAtSalesforce
force-pushed
the
feature/w-16171426_android-update-native-login-sample-app-to-include-qr-code-login-flow
branch
from
8c55911
to
3d60973
Compare
brandonpage
reviewed
Jul 22, 2024
brandonpage
reviewed
Jul 22, 2024
...e/app/src/main/java/com/salesforce/androidnativekotlintemplate/QrCodeEnabledLoginActivity.kt
Outdated
Show resolved
Hide resolved
JohnsonEricAtSalesforce
force-pushed
the
feature/w-16171426_android-update-native-login-sample-app-to-include-qr-code-login-flow
branch
from
3d60973
to
3049445
Compare
wmathurin
reviewed
Jul 22, 2024
wmathurin
approved these changes
Jul 23, 2024
|
Hold merging this to |
brandonpage
approved these changes
Jul 23, 2024
…de Login Flow (Light Cleanup)
…de Login Flow (Documentation Comments To Enable Log In Via UI Bridge API Generated QR Codes)
…de Login Flow (Comment Out Log In Via UI Bridge API Generated QR Codes)
…de Login Flow (Comment In Bulk Of Log In Via UI Bridge API Generated QR Codes)
JohnsonEricAtSalesforce
force-pushed
the
feature/w-16171426_android-update-native-login-sample-app-to-include-qr-code-login-flow
branch
from
78507b6
to
1d33bf1
Compare
JohnsonEricAtSalesforce
deleted the
feature/w-16171426_android-update-native-login-sample-app-to-include-qr-code-login-flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎸 Ready For Review! 🥁
This is a companion to forcedotcom/SalesforceMobileSDK-Android#2594. Do read that in detail before beginning here.
This adds commented code to the Android Native Kotlin template detailing how to enable login via a UI Bridge API generated log in QR code. This is web login specific, so when I chatted with @wmathurin regarding which template this should live in, we easily ruled out the newer Native Login Template. It's also an optional feature that builds logically on the Android Native Kotlin Template, so having it commented out in this context seems to make sense without adding too much clutter.
I used a consistent comment phrase throughout to make it easier to document how to find all the touch points in the template. With those commented out, the template behaves as it does on
dev. For anyone wanting to test, just checkout one earlier commit to test with a fully working configuration.