-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external format validators option #85
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR! I Added some notes. No "critical" issues, just something to discuss.
Oh, sorry, I completely forgot about two other things:
|
Will do, when i have free time :( |
Finally, I've added few tests and little readme, also fixed linter errors and made compatible for erlang versions without maps support, please check. |
The idea is similar to
external_validator
optionThis option allows you to define own string formats and validate it with any
fun(binary()) -> ok | error
.For example:
And somewhere in schema: