Update to work with modern MongoDB #34
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm a total noob at Common Lisp and MongoDB. I just happened to be working through https://github.com/adamtornhill/LispForTheWeb by @adamtornhill, and managed to hack a bit on this to get it working. I've had literally zero looks at the rest of the code, so I'm sure there's much more work to be done. At least this is a start, and hopefully not completely wrong.
npsimons
commented
Sep 12, 2020
| (kv "limit" ,limit) | ||
| (kv "keeptemp" ,keeptemp) | ||
| (when ,limit (kv "limit" ,limit)) |
There was a problem hiding this comment.
- "keeptemp" is apparently no longer supported in calls to MongoDB's mapReduce.
- "limit" is apparently no longer allowed to be zero in calls to MongoDB's mapReduce.
There was a problem hiding this comment.
Well, 0 is "true" in CL, so perhaps (unless (zerop limit) ...) or (when (> limit 0) ...) ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I happened to be working through https://github.com/adamtornhill/LispForTheWeb by @adamtornhill, and managed to hack a bit on this to get it working. I've had literally zero looks at the rest of the code, so I'm sure there's much more work to be done. At least this is a start, and hopefully not completely wrong.