Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hacks): remove redundancies in show_cursor #870

Closed
wants to merge 1 commit into from

Conversation

ttytm
Copy link

@ttytm ttytm commented Jun 22, 2024

I was constantly running into the issue of my cursor disappearing. To get it back, I had to manually(or via a dedicated au) re-set the gcr/guicursor setting.

Checking the code, I see you have some redundant checks for the same condition.
if M._guicursor and if not Util.is_exiting() are both check inside and outside of the scheduled function.

The removed double checks should also result in a minor improvement reducing load.

This fix can also help with the reports that people still experience #114.

@folke
Copy link
Owner

folke commented Jul 6, 2024

Those checks are not redundant and are there for a reason.

That code is also no longer used on newer Neovim versions.

@folke folke closed this Jul 6, 2024
@ttytm ttytm deleted the fix/hacks-show-cursor branch July 6, 2024 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants