Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(config): allow the user to disable default filters by setting the… #776

Closed
wants to merge 1 commit into from

Conversation

Sam-programs
Copy link
Contributor

I am not sure if this is the best way to allow the user to fix the issue.

Fixes #769.

@ilan-schemoul
Copy link

ilan-schemoul commented May 11, 2024

filter = { any = false } can be confusing. Why any = false would mean accept any ?

Other ideas :

  • filter = "no_filter"
  • filter = require("noice").no_filter"
  • filter = "disabled"
  • A new field no_filter so you can do no_filter = true

@Sam-programs
Copy link
Contributor Author

I ended up using a clear_filters key to allow the user to clear the builtin filters, and optionally add their own filters in the same table.
e.g.:

  {
    clear_filters = true,
    event = "notify",
  }

Copy link
Contributor

github-actions bot commented Jul 6, 2024

This PR is stale because it has been open 60 days with no activity.

@ilan-schemoul
Copy link

@folke

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: noice does not display regular messages in history
2 participants