feat(popupmenu): add option to hide scrollbar in popupmenu views. #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 60 days with no activity. |
folke
force-pushed
the
noice-popupmenu-scrollbar-opt
branch
from
7ca957c
to
b91dae0
Compare
folke
changed the title
|
ty! |
folke
pushed a commit
that referenced
this pull request
Jul 7, 2024
🤖 I have created a release *beep* *boop* --- ## [4.4.0](v4.3.1...v4.4.0) (2024-07-06) ### Features * **popupmenu:** add option to hide scrollbar in popupmenu views. ([#686](#686)) ([cd0cd97](cd0cd97)) ### Bug Fixes * **popupmenu:** respect noselect. Fixes [#758](#758) ([d27b118](d27b118)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#603 Added the
scrollbaroption which was only available for certain views, and was not utilized within the popupmenu views. With this fix, popupmenu will honour the scrollbar option as well.