Changes required by Finance Service implementation #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fubica
requested changes
Nov 11, 2021
| @@ -6,6 +6,8 @@ | |||
| import javax.validation.constraints.Size; | |||
| import java.util.*; | |||
|
|
|||
| // TODO explain why this class is duplicated in RAS and ACCS or remove | |||
| // this version | |||
There was a problem hiding this comment.
Duplicated RAS models are removed by PR #32.
|
Then, remove the TODO comment.
… On 12 Nov 2021, at 12:55 , Armstrong Goes ***@***.***> wrote:
@armstrongmsg commented on this pull request.
In src/main/java/cloud/fogbow/accs/core/models/orders/ComputeOrder.java <#35 (comment)>:
> @@ -6,6 +6,8 @@
import javax.validation.constraints.Size;
import java.util.*;
+// TODO explain why this class is duplicated in RAS and ACCS or remove
+// this version
Duplicated RAS models are removed by PR #32 <#32>.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#35 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABVYUTYZTJW2LLL7SCHFS33ULU2GHANCNFSM5HS5QEYQ>.
Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
__________________________________________
Francisco Vilar Brasileiro
Universidade Federal de Campina Grande
Unidade Acadêmica de Sistemas e Computação
Av. Aprígio Veloso, 882, Bloco CO
58.429-900, Campina Grande, PB, Brazil
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include adding order state history to Records and changing date format used by the service to consider hours, minutes and seconds.