use_initialization in vm start #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gekorob
force-pushed
the
using_initialization
branch
from
664913d
to
55f36d6
Compare
|
@gekorob thanks for your contribution!
|
Since the version 4.3.1 of the ovirt-engine-sdk-ruby is possible to start a vm passing the use_initialization param. In this way, according to the VM's OS type it'll be possible to set the correct init section (cloudinit, sysprep, ignition)
gekorob
force-pushed
the
using_initialization
branch
from
55f36d6
to
ea58965
Compare
Rubocop is failing for too many lines in the class, but I think it's a constraint difficult to satisfy in this case. |
|
@gekorob I don't think that PR is not good for merging, but as of now no one is using this function start_with_initialization, so I wonder if another PR in foreman core is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the version 4.3.1 of the ovirt-engine-sdk-ruby is possible to start a vm passing the use_initialization param.
This can be an OS agnostic way to pass init data to the starting vm
depends on:
#93