-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Aggregate sonar coverage #420
base: main
Are you sure you want to change the base?
Conversation
7eae307
to
a7a7191
Compare
c91133f
to
267ad7d
Compare
|
a1861ba
to
f2d68a6
Compare
Will this also fix the never ending failing actions in forks, e.g. https://github.com/XSpielinbox/jollyday/actions or what does one have to do there to fix this? |
No this does not fix your problem. Your problem is that no sonar token is provided and therefore it cannot run sonar. This will fix that all module reports will be aggregated. But I need to think about a good testing modularity, so that I do not need to write duplicated tests. |
Ah, ok. Is there a possibility to disable these sonar test in forks as I don't see an option to provide a sonar without having an account there? |
yes of course. I will look into it. |
@XSpielinbox see #448 please test it :) |
Yes, it works now! Thank you! |
9630364
to
2700ec9
Compare
2700ec9
to
aab080b
Compare
092188c
to
78e8e8c
Compare
78e8e8c
to
14003c5
Compare
|
refs #419
atm we do not track jackson, so we will provide a report aggregate module that will cover all modules for us.