Address sqlite findAll bug #7
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When used with sqlite Model.findAll returns an Array of instances that is not recognised by Keychain as an Array in line 51 (as typeof record returns 'object') and the hook throws a TypeError. Switching to Array.isArray(record) solves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When used with sqlite Model.findAll returns an Array of instances.
They not recognised by Keychain as an Array in sequelize.js line 51 (as typeof record returns 'object'). The hook throws a TypeError line 52 is not called and it attempts to run the afterFind hook on the array and not the record.
Switching to Array.isArray(record) solves the issue.