Desktop Integration #42
Conversation
oshu.desktop
Outdated
| Exec=oshu %F | ||
| MimeType=text/x-osu | ||
| Terminal=true | ||
| Categories=Game;X-Music;X-Rythm |
There was a problem hiding this comment.
I'm surprised this file still exists. Isn't it moved to share/?
share/oshu!.desktop
Outdated
| Exec=oshu %F | ||
| MimeType=text/x-osu | ||
| Terminal=true | ||
| Categories=Game;X-Music;X-Rhythm |
There was a problem hiding this comment.
The bang in the filename may cause trouble for some systems. Calling it oshu without the bang is consistent with the executable file, so I'd rather play it safe.
x-osu.xml
Outdated
| </magic> | ||
| <glob pattern="*.osu"/> | ||
| </mime-type> | ||
| </mime-info> |
There was a problem hiding this comment.
Please remove that one, it's was moved.
share/x-osu.xml
Outdated
| </magic> | ||
| <glob pattern="*.osu"/> | ||
| </mime-type> | ||
| </mime-info> |
There was a problem hiding this comment.
I know I'm the one that suggested x-osu, but since there are other file types for osu!, rather than naively name them x-osb, x-osk, maybe x-osu-something is better.
Here, that would be text/x-osu-beatmap. What do you think?
You're right for text/ vs application/, application is binary according to MDN.
There was a problem hiding this comment.
Almost there! The file should be renamed x-osu-beatmap.xml
How to install: $ desktop-file-install --dir $PREFIX/share/applications oshu.desktop
How to install: $ xdg-mime install x-osu.xml
|
It should be okay now. (I have no idea if you get notifications on pushes) |
|
Actually I did receive the push notification, but didn't have time to merge. Thank you for the contribution! I'll add the autoconf rules next. |
Pull request for #31 (better than commit ids in the issue thread I hope/guess)