issue fixed:[Docs] document the process of rendering a notebooktask in a flyte deck #4463 #1741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
| @@ -32,6 +32,7 @@ | |||
| name="simple-nb", | |||
| notebook_path=str(pathlib.Path(__file__).parent.absolute() / "nb_simple.ipynb"), | |||
| render_deck=True, | |||
| disable_deck=False, | |||
There was a problem hiding this comment.
Sorry, I think this option was deprecated recently. Use enable_deck=True instead please.
cc @samhita-alla
There was a problem hiding this comment.
i have fixed it now
|
@davidmirror-ops can u pls review the pr |
|
@RaghavMangla, it hasn't been fixed yet, right? You need to change it to |
|
Hi, I wanted a little help in this, like in papermill_plugins/simple.py I
set enable_deck=False as was mentioned
But then how to launch it on a flyte deck, is there a tutorial to see that
…On Mon, 7 Oct, 2024, 14:28 Samhita Alla, ***@***.***> wrote:
@RaghavMangla <https://github.com/RaghavMangla>, it hasn't been fixed
yet, right? You need to change it to enable_deck. It would be great if
you could run the workflow on Flyte Sandbox and share a screenshot of the
notebook being rendered in a deck here.
—
Reply to this email directly, view it on GitHub
<#1741 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXGSZMOMOPGU3LNJKD5NA3LZ2JELFAVCNFSM6AAAAABPNNNBDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWGMZDONZXG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
*correction: enable_deck=True
…On Mon, 7 Oct, 2024, 17:41 Raghav Mangla, ***@***.***> wrote:
Hi, I wanted a little help in this, like in papermill_plugins/simple.py I
set enable_deck=False as was mentioned
But then how to launch it on a flyte deck, is there a tutorial to see that
On Mon, 7 Oct, 2024, 14:28 Samhita Alla, ***@***.***> wrote:
> @RaghavMangla <https://github.com/RaghavMangla>, it hasn't been fixed
> yet, right? You need to change it to enable_deck. It would be great if
> you could run the workflow on Flyte Sandbox and share a screenshot of the
> notebook being rendered in a deck here.
>
> —
> Reply to this email directly, view it on GitHub
> <#1741 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AXGSZMOMOPGU3LNJKD5NA3LZ2JELFAVCNFSM6AAAAABPNNNBDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWGMZDONZXG4>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
|
[image: image.png]
Hi! I have attached the screenshot of the HTML page being rendered , this
is my pull request
#1742
On Mon, Oct 7, 2024 at 6:31 PM Raghav Mangla ***@***.***>
wrote:
… *correction: enable_deck=True
On Mon, 7 Oct, 2024, 17:41 Raghav Mangla, ***@***.***>
wrote:
> Hi, I wanted a little help in this, like in papermill_plugins/simple.py
> I set enable_deck=False as was mentioned
> But then how to launch it on a flyte deck, is there a tutorial to see that
>
> On Mon, 7 Oct, 2024, 14:28 Samhita Alla, ***@***.***>
> wrote:
>
>> @RaghavMangla <https://github.com/RaghavMangla>, it hasn't been fixed
>> yet, right? You need to change it to enable_deck. It would be great if
>> you could run the workflow on Flyte Sandbox and share a screenshot of the
>> notebook being rendered in a deck here.
>>
>> —
>> Reply to this email directly, view it on GitHub
>> <#1741 (comment)>,
>> or unsubscribe
>> <https://github.com/notifications/unsubscribe-auth/AXGSZMOMOPGU3LNJKD5NA3LZ2JELFAVCNFSM6AAAAABPNNNBDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOJWGMZDONZXG4>
>> .
>> You are receiving this because you were mentioned.Message ID:
>> ***@***.***>
>>
>
|
|
can you please remove disable deck and add enable deck instead? we can then close the issue. |
|
@RaghavMangla I'm a bit confused. Is this PR not valid anymore and we should review #1742 instead ? |
|
Yes
…On Thu, 10 Oct, 2024, 04:34 David Espejo, ***@***.***> wrote:
@RaghavMangla <https://github.com/RaghavMangla> I'm a bit confused. Is
this PR not valid anymore and we should review #1742
<#1742> instead ?
—
Reply to this email directly, view it on GitHub
<#1741 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXGSZMN2O3MQ27OZLCU3CQLZ2WY6PAVCNFSM6AAAAABPNNNBDKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMBTGU3TKNZSGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Hi @davidmirror-ops @samhita-alla, can u pls review #1742 |
Merged
|
Looks like #1742 has been merged, so I'm going to close this PR, but @RaghavMangla let me know if it should be reopened! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added render_deck=True and disable_deck=False to the notebooktask.
slack thread for reference: https://discuss.flyte.org/t/15484282/hi-all-flyte-rookie-here-maybe-you-can-help-me-out-i-m-tryin#33b0b813-6822-4451-8977-eaec3387a4ff
Issue for reference: flyteorg/flyte#4463