Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Bug: with_overrides for cache doesn't work #2975

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

fix

698d62b
Select commit
Loading
Failed to load commit list.
Open

Fix Bug: with_overrides for cache doesn't work #2975

fix
698d62b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Dec 6, 2024 in 0s

42.28% (-37.34%) compared to 55d4d2d

View this Pull Request on Codecov

42.28% (-37.34%) compared to 55d4d2d

Details

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 42.28%. Comparing base (55d4d2d) to head (698d62b).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
flytekit/core/node.py 0.00% 8 Missing ⚠️
flytekit/tools/serialize_helpers.py 0.00% 2 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (55d4d2d) and HEAD (698d62b). Click for more details.

HEAD has 11 uploads less than BASE
Flag BASE (55d4d2d) HEAD (698d62b)
18 7
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2975       +/-   ##
===========================================
- Coverage   79.62%   42.28%   -37.34%     
===========================================
  Files         200      226       +26     
  Lines       20997    22685     +1688     
  Branches     2705     2710        +5     
===========================================
- Hits        16719     9593     -7126     
- Misses       3511    12876     +9365     
+ Partials      767      216      -551     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.