Skip to content

Commit

Permalink
Incorporate feedback.
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
eapolinario committed Nov 19, 2024
1 parent a4fcfab commit b3a1b0d
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions flytekit/bin/entrypoint.py
Original file line number Diff line number Diff line change
Expand Up @@ -180,6 +180,7 @@ def _dispatch_execute(
logger.warning("Task produces no outputs")
output_file_dict = {_constants.OUTPUT_FILE_NAME: _literal_models.LiteralMap(literals={})}
elif isinstance(outputs, _literal_models.LiteralMap):
# The keys in this map hold the filenames to the offloaded proto literals.
offloaded_literals: Dict[str, _literal_models.Literal] = {}
literal_map_copy = {}

Expand Down Expand Up @@ -214,6 +215,7 @@ def _dispatch_execute(
offloaded_metadata=_literal_models.LiteralOffloadedMetadata(
uri=f"{output_prefix}/{offloaded_filename}",
size_bytes=lit.ByteSize(),
# TODO: remove after https://github.com/flyteorg/flyte/pull/5909 is merged
inferred_type=task_def.interface.outputs[k].type,
),
hash=v.hash if v.hash is not None else compute_hash_string(lit),
Expand Down

0 comments on commit b3a1b0d

Please sign in to comment.