Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse existing executionClusterLabel value during relaunch #minor #873

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

va6996
Copy link

@va6996 va6996 commented May 14, 2024

TL;DR

Support execution cluster labels in flyteconsole. Additionally, reuse existing executionClusterLabel (if available from workflow execution) value for relaunching workflow/tasks

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

When a user specifies the execution cluster label for a single execution, that information is lost when the user clicks relaunch. This change automatically sets the execution cluster to the value set in the original workflow. Subsequent changes to allow specifying the cluster label via UI can be taken up later.

Tracking Issue

NA

Follow-up issue

NA

Copy link

welcome bot commented May 14, 2024

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@va6996 va6996 marked this pull request as ready for review May 15, 2024 00:00
@eapolinario eapolinario requested a review from jsonporter June 12, 2024 22:04
jsonporter
jsonporter previously approved these changes Jul 11, 2024
@jsonporter
Copy link
Contributor

Hey @va6996, sorry for the delay in reviewing your PR; it looks good but there is a minor merge conflict. But its approved now so we can merge it once the conflict is resolved 👍

@va6996
Copy link
Author

va6996 commented Jul 11, 2024

@jsonporter could you take a look again? the review got dismissed

@eapolinario
Copy link
Contributor

@va6996 , can you add a screenshot of the launch form with the executionClusterLabel value pre-filled?

@va6996
Copy link
Author

va6996 commented Aug 13, 2024

@va6996 , can you add a screenshot of the launch form with the executionClusterLabel value pre-filled?

Hi @eapolinario this change did not modify the UI. The cluster details were passed through, based on the current label. This fixed the immediate issue where if a user relaunched a workflow (originally in a custom cluster), the workflow got launched in a different (default) cluster.

@@ -31,7 +31,7 @@ import {
LaunchRoles,
LaunchInterruptibleInputRef,
LaunchOverwriteCacheInputRef,
LaunchRoleInputRef,
LaunchRoleInputRef, LaunchExecutionClusterLabelInputRef,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move to separate line.

@eapolinario
Copy link
Contributor

@FrankFlitton , can you take a look?

@va6996
Copy link
Author

va6996 commented Aug 23, 2024

@eapolinario @FrankFlitton updated based on the comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants