Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: show correct details panel io #820

Merged
merged 1 commit into from
Oct 11, 2023
Merged

fix: show correct details panel io #820

merged 1 commit into from
Oct 11, 2023

Conversation

ursucarina
Copy link
Contributor

TL;DR

Shows correct IO info in details panel

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

@ursucarina ursucarina requested review from a team, FrankFlitton and jsonporter and removed request for a team October 11, 2023 17:15
@ursucarina ursucarina enabled auto-merge (squash) October 11, 2023 17:15
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (f9ec9b9) 63.34% compared to head (ca3c48b) 63.34%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #820   +/-   ##
=======================================
  Coverage   63.34%   63.34%           
=======================================
  Files         527      527           
  Lines       13400    13400           
  Branches     2554     2554           
=======================================
  Hits         8488     8488           
  Misses       4912     4912           
Files Coverage Δ
...ackages/console/src/components/Literals/helpers.ts 82.92% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ursucarina ursucarina merged commit 3edbb2b into master Oct 11, 2023
11 checks passed
@ursucarina ursucarina deleted the carina/io branch October 11, 2023 23:01
@flyte-bot
Copy link
Collaborator

🎉 This PR is included in version 1.9.8 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants