Overwriting of cached task outputs for a single execution #minor #616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #616 +/- ##
==========================================
+ Coverage 68.31% 68.38% +0.07%
==========================================
Files 448 449 +1
Lines 10673 10714 +41
Branches 1841 1849 +8
==========================================
+ Hits 7291 7327 +36
- Misses 3382 3387 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
MorpheusXAUT
force-pushed
the
cache-eviction-skip-cache
branch
from
07fd5ae to
b6a9984
Compare
MorpheusXAUT
changed the title
|
cc @MorpheusXAUT / @jsonporter any progress on this? |
added 5 commits
January 3, 2023 14:05
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
Allows for stopping docker run via CTRL+C Signed-off-by: Nick Müller <[email protected]>
Signed-off-by: Nick Müller <[email protected]>
MorpheusXAUT
force-pushed
the
cache-eviction-skip-cache
branch
from
b6a9984 to
e338fa4
Compare
@kumare3 nothing new from my side regarding this PR - just rebased onto current master to resolve the merge conflicts. |
|
🎉 This PR is included in version 1.4.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Added checkbox to toggle cache overwriting for a single execution.
Type
Are all requirements met?
Complete description
flyteconsole now supports overwriting of cached outputs for a single workflow or task execution. A checkbox was added to the launch/relaunch forms, similar to the interruptible override.
The protobuf timestamp helper changes were added since my local version of latest flyteadmin and flyteconsole seemed to return
numbers instead ofLongs, causing the UI to error while converting protobuf timestamps. Thus, a simple type check was added - I can revert this if it's not desired/something broken on my local side.As this uses a currently unmergedflyteidlversion, the PR is created as a draft (for review) until a new version offlyteidlis available.Tracking Issue
flyteorg/flyte#2867
Follow-up issue
NA