merged master

Signed-off-by: Kevin Su <[email protected]>

.github/workflows/checks.yml

@@ -82,7 +82,7 @@ jobs:
       - name: Setup Node.js
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: 18.16.1
       - name: Install dependencies
         run: yarn install --immutable
       - name: Release
@@ -92,7 +92,8 @@ jobs:
           GIT_AUTHOR_EMAIL: "[email protected]"
           GIT_COMMITTER_NAME: "flyte bot"
           GIT_COMMITTER_EMAIL: "[email protected]"
-        run: npx semantic-release
+          CI: "true"
+        run: npx [email protected]
 
   check_for_tag:
     name: Get Release Tag

.husky/commit-msg

@@ -1,4 +1,7 @@
 #!/usr/bin/env sh
 . "$(dirname -- "$0")/_/husky.sh"
 
+# exit if in a CI environment
+[ -n "$CI" ] && exit 0
+
 npx --no -- commitlint --edit ${1}

.husky/pre-commit

@@ -1,5 +1,7 @@
 #!/usr/bin/env sh
+
 . "$(dirname -- "$0")/_/husky.sh"
+# exit if in a CI environment
 [ -n "$CI" ] && exit 0
 
 echo "Linting staged files..."

.npmrc

@@ -0,0 +1,3 @@
+# last modified: 27 July 2016
+# Set a new registry for a scoped package
+# @myscope:registry=https://mycustomregistry.example.org

release.config.js → .releaserc.js

@@ -1,4 +1,5 @@
 const { execSync } = require('child_process');
+const path = require('path');
 
 /**
  *
@@ -16,7 +17,14 @@ function getProdConfiguration() {
             '# Changelog\n\nAll notable changes to this project will be documented in this file. See\n[Conventional Commits](https://conventionalcommits.org) for commit guidelines.',
         },
       ],
-      ['@semantic-release/npm', { npmPublish: false }],
+      // set package.json version
+      [
+        '@semantic-release/exec',
+        {
+          // eslint-disable-next-line no-template-curly-in-string
+          prepareCmd: 'make update_npmversion VERSION=${nextRelease.version}',
+        },
+      ],
       '@semantic-release/github',
     ],
   };
@@ -55,7 +63,14 @@ function getTestConfiguration() {
             '# Changelog\n\nAll notable changes to this project will be documented in this file. See\n[Conventional Commits](https://conventionalcommits.org) for commit guidelines.',
         },
       ],
-      ['@semantic-release/npm', { npmPublish: false }],
+      // set package.json version
+      [
+        '@semantic-release/exec',
+        {
+          // eslint-disable-next-line no-template-curly-in-string
+          prepareCmd: 'make update_npmversion VERSION=${nextRelease.version}',
+        },
+      ],
       // ["@semantic-release/github", {
       //   "verifyConditions": false,
       //   "publish": false,

CONTRIBUTING.md

@@ -210,4 +210,4 @@ yarn install
 
    Your new localhost is [localhost.different.admin.service.com](http://localhost.different.admin.service.com)
 
-> Ensure you don't have `ADMIN_API_URL` or `DISABLE_AUTH` set (e.g., in your `/.profile`.)
+> Ensure you don't have `ADMIN_API_URL` set (e.g., in your `/.profile`.)

Makefile

@@ -57,6 +57,4 @@ PLACEHOLDER_NPM := "version": "0.0.0-develop"
 
 .PHONY: update_npmversion
 update_npmversion:
-	echo "Updating client-app version to: $(VERSION)"
-	grep '$(PLACEHOLDER_NPM)' website/package.json
-	sed -i 's/$(PLACEHOLDER_NPM)/"version": "$(VERSION)"/g' website/package.json
+	./script/update_npmversion.sh ${VERSION}

README.md

@@ -46,7 +46,7 @@ For help with installing dependencies look into
    ```
 2. Now, export the following env variables:
 
-   `export ADMIN_API_URL=http://localhost:30080 export DISABLE_AUTH=1`
+   `export ADMIN_API_URL=http://localhost:30080`
 
    > You can persist these environment variables either in the current shell or in a `.env` file at the root
    > of the repository. A `.env` file will persist the settings across multiple terminal
@@ -116,12 +116,10 @@ few environment variables in your run command to setup the appliation.
 
 `CONFIG_DIR="/etc/flyte/config"` (required)
 
-`DISABLE_AUTH="1"` (optional)
-
 This example assumes building from `v1.0.0` on port `8080`
 
 ```bash
-docker run -p 8080:8080 -e BASE_URL="/console" -e CONFIG_DIR="/etc/flyte/config" -e DISABLE_AUTH="1" ghcr.io/flyteorg/flyteconsole:v1.0.0
+docker run -p 8080:8080 -e BASE_URL="/console" -e CONFIG_DIR="/etc/flyte/config" ghcr.io/flyteorg/flyteconsole:v1.0.0
 ```
 
 ### Run the server

commitlint.config.js

@@ -1 +1,4 @@
-module.exports = { extends: ['@commitlint/config-conventional'] };
+module.exports = {
+  extends: ['@commitlint/config-conventional'],
+  ignores: [commit => commit.includes('[skip ci]')],
+};