Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve error message in the agent plugin #6114

Merged
merged 3 commits into from
Dec 18, 2024
Merged

improve error message in the agent plugin #6114

merged 3 commits into from
Dec 18, 2024

Conversation

pingsutw
Copy link
Member

Tracking issue

NA

Why are the changes needed?

Improve the error message

What changes were proposed in this pull request?

Update error message

How was this patch tested?

Setup process

Screenshots

Screenshot 2024-12-17 at 1 12 14 PM

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 8 lines in your changes missing coverage. Please review.

Project coverage is 36.98%. Comparing base (e21a6ad) to head (cabe46a).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...yteplugins/go/tasks/plugins/webapi/agent/plugin.go 33.33% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6114   +/-   ##
=======================================
  Coverage   36.98%   36.98%           
=======================================
  Files        1318     1318           
  Lines      132449   132450    +1     
=======================================
+ Hits        48984    48987    +3     
+ Misses      79212    79209    -3     
- Partials     4253     4254    +1     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.06% <ø> (+0.02%) ⬆️
unittests-flytecopilot 30.99% <ø> (ø)
unittests-flytectl 62.29% <ø> (ø)
unittests-flyteidl 7.23% <ø> (ø)
unittests-flyteplugins 53.85% <33.33%> (-0.01%) ⬇️
unittests-flytepropeller 42.60% <ø> (ø)
unittests-flytestdlib 55.13% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario
Copy link
Contributor

The unit tests failure are real: https://github.com/flyteorg/flyte/actions/runs/12381508644/job/34560236391?pr=6114. Can you take a look?

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw merged commit 1f533ab into master Dec 18, 2024
51 of 52 checks passed
@pingsutw pingsutw deleted the agent-error branch December 18, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants