Special-case type annotations to force cache invalidations for msgpack-binary literals #6078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k-binary literals Signed-off-by: Eduardo Apolinario <[email protected]>
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6078 +/- ##
=======================================
Coverage 37.10% 37.10%
=======================================
Files 1318 1318
Lines 132331 132335 +4
=======================================
+ Hits 49100 49104 +4
Misses 78959 78959
Partials 4272 4272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wild-endeavor
approved these changes
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
https://linear.app/unionai/issue/DX-1202/add-cacke-key-attributes-to-typeannotation
Why are the changes needed?
In order to help the transition to the new version of flytekit, we special-case type annotations that contain a certain key, namely
cache-key-metadata. The presence of this key will indicate that we should not nil out the type annotation field in the CRD.A change in flytekit will accompany this.
What changes were proposed in this pull request?
Special-case
TypeAnnotationobjects that contain a key calledcache-key-metadata, which, as the name suggests, will contain information used to generate unique cache keys.How was this patch tested?
Unit tests and sandbox.
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link