Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sub_node_interface field to array node (#6018) #6067

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

eapolinario
Copy link
Contributor

cherry-pick 92f8abb into release-v1.13.

* add is_original_sub_node_interface field to array node

Signed-off-by: Paul Dittamo <[email protected]>

* update idl

Signed-off-by: Paul Dittamo <[email protected]>

* make arraynode compilation backwards compatible

Signed-off-by: Paul Dittamo <[email protected]>

* use boolvalue for is_original_sub_node_interface

Signed-off-by: Paul Dittamo <[email protected]>

---------

Signed-off-by: Paul Dittamo <[email protected]>
Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 36.79%. Comparing base (88d6e6a) to head (e117fb0).
Report is 1 commits behind head on release-v1.13.

Files with missing lines Patch % Lines
flyteidl/gen/pb-go/flyteidl/core/workflow.pb.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@                Coverage Diff                @@
##           release-v1.13    #6067      +/-   ##
=================================================
- Coverage          36.79%   36.79%   -0.01%     
=================================================
  Files               1309     1309              
  Lines             131041   131046       +5     
=================================================
- Hits               48222    48216       -6     
- Misses             78626    78637      +11     
  Partials            4193     4193              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.00% <ø> (-0.03%) ⬇️
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.40% <ø> (ø)
unittests-flyteidl 6.90% <0.00%> (-0.01%) ⬇️
unittests-flyteplugins 53.67% <ø> (ø)
unittests-flytepropeller 42.88% <ø> (ø)
unittests-flytestdlib 55.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eapolinario eapolinario merged commit 96df3b9 into release-v1.13 Dec 2, 2024
46 of 49 checks passed
@eapolinario eapolinario deleted the backport-6018-to-release-v1.13 branch December 2, 2024 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants