Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flyteadmin digest comparison should rely on database semantics #6058

fix lint error

28481a0
Select commit
Loading
Failed to load commit list.
Merged

Flyteadmin digest comparison should rely on database semantics #6058

fix lint error
28481a0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 5, 2024 in 0s

37.11% (+0.00%) compared to 0585fba

View this Pull Request on Codecov

37.11% (+0.00%) compared to 0585fba

Details

Codecov Report

Attention: Patch coverage is 63.63636% with 8 lines in your changes missing coverage. Please review.

Project coverage is 37.11%. Comparing base (0585fba) to head (28481a0).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
flyteadmin/pkg/manager/impl/task_manager.go 60.00% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6058   +/-   ##
=======================================
  Coverage   37.10%   37.11%           
=======================================
  Files        1318     1318           
  Lines      132326   132337   +11     
=======================================
+ Hits        49099    49112   +13     
+ Misses      78955    78952    -3     
- Partials     4272     4273    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.