[Docs][flyteagent] Added description of exception deletion cases. #6039
+41
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6039 +/- ##
=======================================
Coverage 37.10% 37.10%
=======================================
Files 1318 1318
Lines 132326 132326
=======================================
+ Hits 49100 49104 +4
+ Misses 78954 78950 -4
Partials 4272 4272
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…eorg#6034) * feat: fix Union type with dataclass ambiguous error Signed-off-by: mao3267 <[email protected]> * fix: direct json comparison for superset Signed-off-by: mao3267 <[email protected]> * fix: go.mod missing entry for error Signed-off-by: mao3267 <[email protected]> * fix: update go module and sum Signed-off-by: mao3267 <[email protected]> * refactor: gci format Signed-off-by: mao3267 <[email protected]> * test: add dataset casting tests for same (one/two levels) and superset (one level) dataclass Signed-off-by: mao3267 <[email protected]> * fix: support Pydantic BaseModel comparison Signed-off-by: mao3267 <[email protected]> * fix: handle nested pydantic basemodel Signed-off-by: mao3267 <[email protected]> * Reviews from Eduardo Signed-off-by: Future-Outlier <[email protected]> * fix: support strict subset match Signed-off-by: mao3267 <[email protected]> * test: update strict subset match test Signed-off-by: mao3267 <[email protected]> * fix: missing go mod entry Signed-off-by: mao3267 <[email protected]> * fix: missing go mod entry Signed-off-by: mao3267 <[email protected]> * fix: go mod entry Signed-off-by: mao3267 <[email protected]> * make go-tidy Signed-off-by: Future-Outlier <[email protected]> * comments Signed-off-by: Future-Outlier <[email protected]> * fix: strict subset match with draft 2020-12 mashumaro Signed-off-by: mao3267 <[email protected]> * refactor: make go-tidy Signed-off-by: mao3267 <[email protected]> * fix: support strict subset match with ambiguity Signed-off-by: mao3267 <[email protected]> * fix: change test name and fix err Signed-off-by: mao3267 <[email protected]> * Add comments Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * add flytectl go-tidy in makefile Signed-off-by: Future-Outlier <[email protected]> * nit Signed-off-by: Future-Outlier <[email protected]> * fix: add comment for error checking Signed-off-by: mao3267 <[email protected]> * test: basemodel castable test, two level dataclass and ParentToChild failure Signed-off-by: mao3267 <[email protected]> * fix: add logger for jsonschema compiler Signed-off-by: mao3267 <[email protected]> * fix: add logger for marshal and compiler Signed-off-by: mao3267 <[email protected]> * better error msg format Signed-off-by: Future-Outlier <[email protected]> --------- Signed-off-by: mao3267 <[email protected]> Signed-off-by: Future-Outlier <[email protected]> Co-authored-by: Future-Outlier <[email protected]> Signed-off-by: SZL741023 <[email protected]>
Signed-off-by: SZL741023 <[email protected]>
Future-Outlier
changed the title
There was a problem hiding this comment.
this is the correct doc link
https://flyte--6039.org.readthedocs.build/en/6039/user_guide/flyte_agents/developing_agents.html
cc @SZL741023
Signed-off-by: Future-Outlier <[email protected]>
Signed-off-by: Future-Outlier <[email protected]>
Future-Outlier
approved these changes
Nov 28, 2024
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Why are the changes needed?
What changes were proposed in this pull request?
Added description of exception deletion cases.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link
Developing agents