Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Align code lines of TensorFlow types with flytesnacks #5983

Merged
merged 2 commits into from
Nov 12, 2024

Conversation

JiangJiaWei1103
Copy link
Contributor

@JiangJiaWei1103 JiangJiaWei1103 commented Nov 10, 2024

Why are the changes needed?

The code lines of Tensorflow types are out of sync of the Flytesnacks example.

What changes were proposed in this pull request?

Fix code lines to align with the code example in flytesnacks.

Docs link

https://flyte--5983.org.readthedocs.build/en/5983/user_guide/data_types_and_io/tensorflow_type.html

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.90%. Comparing base (25cfe16) to head (2f72dd3).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5983      +/-   ##
==========================================
+ Coverage   33.09%   36.90%   +3.80%     
==========================================
  Files        1013     1310     +297     
  Lines      107489   131372   +23883     
==========================================
+ Hits        35570    48477   +12907     
- Misses      68767    78682    +9915     
- Partials     3152     4213    +1061     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.05% <ø> (?)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.39% <ø> (-0.05%) ⬇️
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.84% <ø> (ø)
unittests-flytepropeller 42.90% <ø> (ø)
unittests-flytestdlib 55.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@davidmirror-ops davidmirror-ops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@davidmirror-ops davidmirror-ops merged commit 3409ae1 into flyteorg:master Nov 12, 2024
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants