Improve resource manager test coverage #5973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5973 +/- ##
==========================================
+ Coverage 36.97% 37.00% +0.03%
==========================================
Files 1318 1318
Lines 132516 132516
==========================================
+ Hits 49000 49043 +43
+ Misses 79258 79229 -29
+ Partials 4258 4244 -14
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
troychiu
reviewed
Nov 9, 2024
| Attributes: &admin.WorkflowAttributes{}, | ||
| } | ||
| _, failError := manager.UpdateWorkflowAttributes(context.Background(), request) | ||
| assert.Error(t, failError) |
There was a problem hiding this comment.
Can we also make sure it returns the right error?
There was a problem hiding this comment.
all new added error test cases have been error type and error message checked in the code
| } | ||
|
|
||
| _, validationError := manager.GetWorkflowAttributes(context.Background(), request) | ||
| assert.Error(t, validationError) |
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
…lete function error Signed-off-by: Arthur <[email protected]>
…ete function error Signed-off-by: Arthur <[email protected]>
…unction error Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
…d error message check for UpdateProjectDomainAttributes Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
…r DeleteProjectDomainAttributes Signed-off-by: Arthur <[email protected]>
Signed-off-by: Arthur <[email protected]>
luckyarthur
force-pushed
the
improve-source-manager-test-coverage
branch
from
90220c0 to
0372f31
Compare
troychiu
changed the title
Signed-off-by: Eduardo Apolinario <[email protected]>
eapolinario
approved these changes
Dec 26, 2024
|
Congrats on merging your first pull request! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
the resource manager test coverage is 64.04%, which is behind 80%, this PR improves the coverage
What changes were proposed in this pull request?
add more test case coverage to resource manager in this pull request
How was this patch tested?
tests were run after every commit
Check all the applicable boxes