add friendly name execution object column #5965
Open
+78
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: wayner0628 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5965 +/- ##
==========================================
+ Coverage 36.85% 36.95% +0.10%
==========================================
Files 1310 1311 +1
Lines 131227 131409 +182
==========================================
+ Hits 48362 48562 +200
+ Misses 78668 78632 -36
- Partials 4197 4215 +18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
Signed-off-by: wayner0628 <[email protected]>
pingsutw
reviewed
Nov 27, 2024
pingsutw
reviewed
Nov 27, 2024
There was a problem hiding this comment.
We also need to update the migration since we add a new column.
https://github.com/flyteorg/flyte/blob/master/flyteadmin/pkg/repositories/config/migrations.go#L1278
Signed-off-by: wayner0628 <[email protected]>
|
@pingsutw and I chatted about this and the conclusion is that we shouldn't store the friendly name as a column in the DB, instead, this should be a presentation-only property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#5964
Why are the changes needed?
We want to improve execution name readability, while avoid a high possibility of collision using friendly names, so we make it a execution object
See the discussion: #5740
What changes were proposed in this pull request?
Execution objects now include a friendly name column.
How was this patch tested?
This PR focuses on updates to the execution model column only, as there are no modifications to
Flyteconsole. The changes won't reflect on ui appearance.Setup process
Screenshots
Check all the applicable boxes
Related PRs
#5637
#5740
Docs link