-
Notifications
You must be signed in to change notification settings - Fork 671
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve test coverage of quality of service #5963
base: master
Are you sure you want to change the base?
Improve test coverage of quality of service #5963
Conversation
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5963 +/- ##
===========================================
+ Coverage 36.81% 50.86% +14.05%
===========================================
Files 1310 1164 -146
Lines 131034 89475 -41559
===========================================
- Hits 48237 45512 -2725
+ Misses 78611 39956 -38655
+ Partials 4186 4007 -179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Why are the changes needed?
the test coverage of quality_of_service is 62.12%, which is far away from 80%, so I add some test cases in this PR.
What changes were proposed in this pull request?
to improve the test coverage flyteadmin/pkg/manager/impl/executions/quality_of_service.go, more test cases are added.
some nil pointer bugs found when add test cases, and fixed in this PR.
more details about the nil pointer bug explanation:
How was this patch tested?
Check all the applicable boxes