Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: align the default config output #5947

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

Terryhung
Copy link
Contributor

@Terryhung Terryhung commented Oct 31, 2024

Tracking issue

Closes #3186

Why are the changes needed?

What changes were proposed in this pull request?

  1. Removing Unused Fields: Remove storage.connection. This reduces clutter, making the config cleaner and easier to understand.
  2. Aligning Configurations: Ensures flytectl config init and flytectl demo start produce consistent configs, simplifying setup and usage. Align the admin.endpoint: dns:///localhost:30080.

How was this patch tested?

Setup process

unit test

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.84%. Comparing base (dcdd472) to head (1781a1b).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5947      +/-   ##
==========================================
- Coverage   36.84%   36.84%   -0.01%     
==========================================
  Files        1309     1309              
  Lines      130994   130989       -5     
==========================================
- Hits        48271    48263       -8     
- Misses      78533    78536       +3     
  Partials     4190     4190              
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (ø)
unittests-flytecopilot 11.73% <ø> (ø)
unittests-flytectl 62.38% <100.00%> (-0.07%) ⬇️
unittests-flyteidl 6.92% <ø> (ø)
unittests-flyteplugins 53.64% <ø> (ø)
unittests-flytepropeller 43.02% <ø> (ø)
unittests-flytestdlib 55.41% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Terryhung Terryhung marked this pull request as ready for review October 31, 2024 15:26
@Terryhung Terryhung changed the title [WIP] align the default config output Fix: align the default config output Oct 31, 2024
@Terryhung Terryhung changed the title Fix: align the default config output fix: align the default config output Oct 31, 2024
@pingsutw pingsutw merged commit 704f8eb into flyteorg:master Nov 1, 2024
54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[FlyteCTL Feature] Make default output of flytectl config init consistent with the demo sandbox config
2 participants