Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport #5788, #5855, and #5769 to release v1.13 #5890

Merged
merged 3 commits into from
Oct 23, 2024
+3,149 −684

Upstream contributions from Union.ai (#5769)

3aab668
Select commit
Loading
Failed to load commit list.
Merged

Backport #5788, #5855, and #5769 to release v1.13 #5890

Upstream contributions from Union.ai (#5769)
3aab668
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 22, 2024 in 1s

36.75% (+0.43%) compared to 881d7a2

View this Pull Request on Codecov

36.75% (+0.43%) compared to 881d7a2

Details

Codecov Report

Attention: Patch coverage is 51.69661% with 484 lines in your changes missing coverage. Please review.

Project coverage is 36.75%. Comparing base (881d7a2) to head (3aab668).

Files with missing lines Patch % Lines
flyteadmin/pkg/manager/mocks/resource_interface.go 0.00% 275 Missing ⚠️
...eller/pkg/controller/nodes/array/event_recorder.go 67.74% 23 Missing and 7 partials ⚠️
flytestdlib/promutils/scope.go 59.67% 23 Missing and 2 partials ⚠️
...eplugins/go/tasks/plugins/k8s/dask/config_flags.go 40.00% 21 Missing ⚠️
...er/pkg/controller/nodes/task/future_file_reader.go 0.00% 20 Missing ⚠️
flytestdlib/database/db.go 0.00% 18 Missing ⚠️
flytepropeller/pkg/controller/controller.go 0.00% 15 Missing ⚠️
flyteadmin/pkg/server/service.go 0.00% 12 Missing ⚠️
flyteadmin/auth/authzserver/provider.go 42.10% 10 Missing and 1 partial ⚠️
...ytestdlib/promutils/labeled/histogram_stopwatch.go 81.63% 5 Missing and 4 partials ⚠️
... and 11 more
Additional details and impacted files 
@@                Coverage Diff                @@
##           release-v1.13    #5890      +/-   ##
=================================================
+ Coverage          36.31%   36.75%   +0.43%     
=================================================
  Files               1304     1309       +5     
  Lines             110072   130801   +20729     
=================================================
+ Hits               39974    48075    +8101     
- Misses             65936    78551   +12615     
- Partials            4162     4175      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov