Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable echo plugin by default #5679

Merged
merged 4 commits into from
Aug 28, 2024
Merged

Enable echo plugin by default #5679

merged 4 commits into from
Aug 28, 2024

Conversation

pingsutw
Copy link
Member

Tracking issue

NA

Why are the changes needed?

flyteorg/flytekit#2654 adds an echo task, which can be used in the conditional workflow. However, it doesn't work out of the box. The platform engineer has to update the propeller config to enable it.

What changes were proposed in this pull request?

Enable it by default.

How was this patch tested?

import typing

from flytekit import ImageSpec, conditional, task, workflow
from flytekit.core.task import Echo

new_flytekit = "git+https://github.com/flyteorg/flytekit.git@2349ceeaf74fe6449b66eee54be5667aec0b45ab"

custom_image = ImageSpec(
    registry="localhost:30000",
    packages=[new_flytekit],
    apt_packages=["git"],
    builder="default",
)


echo1 = Echo(name="echo", inputs={"a": typing.Optional[float]})


@task(container_image=custom_image)
def t1(radius: float) -> typing.Optional[float]:
    return 2 * 3.14 * radius


@workflow
def wf1(radius: float) -> typing.Optional[float]:
    return (
        conditional("shape_properties_with_multiple_branches")
        .if_((radius >= 0.1) & (radius < 1.0))
        .then(t1(radius=radius))
        .else_()
        .then(echo1(a=radius))
    )

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

NA

Docs link

NA

Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw mentioned this pull request Aug 20, 2024
3 tasks
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.18%. Comparing base (7136919) to head (c56684b).
Report is 154 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5679      +/-   ##
==========================================
- Coverage   36.18%   36.18%   -0.01%     
==========================================
  Files        1302     1302              
  Lines      109614   109614              
==========================================
- Hits        39660    39659       -1     
- Misses      65809    65810       +1     
  Partials     4145     4145              
Flag Coverage Δ
unittests-datacatalog 51.37% <ø> (ø)
unittests-flyteadmin 55.33% <ø> (ø)
unittests-flytecopilot 12.17% <ø> (ø)
unittests-flytectl 62.18% <ø> (ø)
unittests-flyteidl 7.12% <ø> (ø)
unittests-flyteplugins 53.34% <ø> (ø)
unittests-flytepropeller 41.71% <ø> (ø)
unittests-flytestdlib 55.33% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

eapolinario
eapolinario previously approved these changes Aug 21, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we build an image and check it in the configmap?

Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Future-Outlier
Copy link
Member

Can we build an image and check it in the configmap?

The configmap works.

image image

@pingsutw pingsutw merged commit 5c147ef into master Aug 28, 2024
55 checks passed
@pingsutw pingsutw deleted the enable-echo branch August 28, 2024 17:09
pmahindrakar-oss pushed a commit that referenced this pull request Sep 9, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: pmahindrakar-oss <[email protected]>
bgedik pushed a commit to bgedik/flyte that referenced this pull request Sep 12, 2024
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Bugra Gedik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants