Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Spark pod template overrides #4183

Merged
merged 7 commits into from
Oct 11, 2023

Fix lints

94cbc22
Select commit
Loading
Failed to load commit list.
Merged

Implement Spark pod template overrides #4183

Fix lints
94cbc22
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/patch succeeded Oct 10, 2023 in 0s

73.43% of diff hit (target 59.45%)

View this Pull Request on Codecov

73.43% of diff hit (target 59.45%)

Annotations

Check warning on line 14 in flyteplugins/go/tasks/pluginmachinery/flytek8s/non_interruptible.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/non_interruptible.go#L13-L14

Added lines #L13 - L14 were not covered by tests

Check warning on line 25 in flyteplugins/go/tasks/pluginmachinery/flytek8s/non_interruptible.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/non_interruptible.go#L24-L25

Added lines #L24 - L25 were not covered by tests

Check warning on line 34 in flyteplugins/go/tasks/pluginmachinery/flytek8s/non_interruptible.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/non_interruptible.go#L28-L34

Added lines #L28 - L34 were not covered by tests

Check warning on line 278 in flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go#L274-L278

Added lines #L274 - L278 were not covered by tests

Check warning on line 280 in flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/pluginmachinery/flytek8s/pod_helper.go#L280

Added line #L280 was not covered by tests

Check warning on line 80 in flyteplugins/go/tasks/plugins/k8s/spark/spark.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/spark/spark.go#L80

Added line #L80 was not covered by tests

Check warning on line 140 in flyteplugins/go/tasks/plugins/k8s/spark/spark.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/spark/spark.go#L139-L140

Added lines #L139 - L140 were not covered by tests

Check warning on line 180 in flyteplugins/go/tasks/plugins/k8s/spark/spark.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/spark/spark.go#L179-L180

Added lines #L179 - L180 were not covered by tests

Check warning on line 184 in flyteplugins/go/tasks/plugins/k8s/spark/spark.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/spark/spark.go#L183-L184

Added lines #L183 - L184 were not covered by tests

Check warning on line 210 in flyteplugins/go/tasks/plugins/k8s/spark/spark.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/spark/spark.go#L209-L210

Added lines #L209 - L210 were not covered by tests

Check warning on line 214 in flyteplugins/go/tasks/plugins/k8s/spark/spark.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flyteplugins/go/tasks/plugins/k8s/spark/spark.go#L213-L214

Added lines #L213 - L214 were not covered by tests