Skip to content

Commit

Permalink
Revert unintended change to executor
Browse files Browse the repository at this point in the history
Signed-off-by: Eduardo Apolinario <[email protected]>
  • Loading branch information
eapolinario committed Nov 4, 2024
1 parent f0aa3cb commit 28c7a56
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions flytepropeller/pkg/controller/nodes/executor.go
Original file line number Diff line number Diff line change
Expand Up @@ -754,16 +754,8 @@ func (c *nodeExecutor) preExecute(ctx context.Context, dag executors.DAGStructur
dataDir := nodeStatus.GetDataDir()
t := c.metrics.NodeInputGatherLatency.Start(ctx)
defer t.Stop()
var err error
taskTemplate, err := nCtx.TaskReader().Read(ctx)
if err != nil {
c.metrics.ResolutionFailure.Inc(ctx)
logger.Warningf(ctx, "Failed to read task template for Node. Error [%v]", err)
return handler.PhaseInfoFailure(core.ExecutionError_SYSTEM, "TaskTemplateReadFailure", err.Error(), nil), nil
}
inputsInterface := taskTemplate.Interface.Inputs
inputsInterface["abc"].Type
// Can execute
var err error
nodeInputs, err = Resolve(ctx, c.outputResolver, nCtx.ContextualNodeLookup(), node.GetID(), node.GetInputBindings())
// TODO we need to handle retryable, network errors here!!
if err != nil {
Expand Down

0 comments on commit 28c7a56

Please sign in to comment.